Re: [PATCH md 3 of 4] Delete unplug timer before shutting down md array.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Morton <akpm@xxxxxxxx> wrote:
>
> NeilBrown <neilb@xxxxxxxxxxxxxxx> wrote:
> >
> > As the unplug timer can potentially fire at any time, and
> >  and it access data that is released by the md ->stop function,
> >  we need to del_timer_sync before releasing that data.
> 
> raid really shouldn't know about unplug_timer.
> 

I mean, if we're actually destroying the queue then blk_cleanup_queue()
should have done the right thing here.  If we're not destroying the queue
then an unplug timer expiry should be benign.

Bit confused as to what's happening here.
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux