Well, it looks like that bit patch bomb wasn't quite perfect..
Here are three more, against 2.5.23, that address:
- "raidstart" would hang
- compiler warning
- compile failure when not SMP.
NeilBrown
###Comments for ChangeSet
... as autostart_array does it's own locking.
----------- Diffstat output ------------
./drivers/md/md.c | 26 ++++++++++++++------------
1 files changed, 14 insertions(+), 12 deletions(-)
--- ./drivers/md/md.c 2002/06/19 04:28:22 1.1
+++ ./drivers/md/md.c 2002/06/19 23:20:56 1.2
@@ -2546,6 +2546,20 @@
goto abort;
}
+
+ if (cmd == START_ARRAY) {
+ /* START_ARRAY doesn't need to lock the array as autostart_array
+ * does the locking, and it could even be a different array
+ */
+ err = autostart_array(val_to_kdev(arg));
+ if (err) {
+ printk(KERN_WARNING "md: autostart %s failed!\n",
+ partition_name(val_to_kdev(arg)));
+ goto abort;
+ }
+ goto done;
+ }
+
err = mddev_lock(mddev);
if (err) {
printk(KERN_INFO "md: ioctl lock interrupted, reason %d, cmd %d\n",
@@ -2580,18 +2594,6 @@
printk(KERN_WARNING "md: couldnt set array info. %d\n", err);
goto abort_unlock;
}
- }
- goto done_unlock;
-
- case START_ARRAY:
- /*
- * possibly make it lock the array ...
- */
- err = autostart_array(val_to_kdev(arg));
- if (err) {
- printk(KERN_WARNING "md: autostart %s failed!\n",
- partition_name(val_to_kdev(arg)));
- goto abort_unlock;
}
goto done_unlock;
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
