On Mon, 2019-07-15 at 21:41 +0200, Georg Chini wrote: > On 15.07.19 14:40, Tanu Kaskinen wrote: > > As for what should be copied from module-rescue-streams to the core - > > the shutdown check is good, but I'm not sure anything else needs to be > > copied. If a sink input can't be moved to the default sink, I think > > it's OK to let it be killed rather than moving it to a sink that is > > neither the default sink nor the sink input's preferred sink. That's > > consistent with the fact that creating a new sink input fails if it > > can't use the default sink. > I don't understand the last sentence. I would prefer to try > to move a sink-input elsewhere when it cannot move to > the default sink, but I am also OK with killing it. When an application creates a stream and doesn't specify a sink, PulseAudio will try to use the default sink. If that doesn't work, the stream creation fails instead of PulseAudio trying to find some other sink that works. To me it would make sense to be consistent in these two cases: creating a new stream and rescuing a stream from a sink that is being removed. If we care so much about keeping a stream alive that killing it is the absolute last resort, then we probably should also try to find a working alternative when the default sink doesn't work for a newly created sink input. However, the simpler solution of just killing the stream seems like an acceptable policy to me. -- Tanu https://www.patreon.com/tanuk https://liberapay.com/tanuk _______________________________________________ pulseaudio-discuss mailing list pulseaudio-discuss@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
