On Sat, 2019-03-23 at 17:05 +0200, Tanu Kaskinen wrote: > On Fri, 2019-03-22 at 11:44 +0100, Pali Rohár wrote: > > Hello, may I ask for review of this patch series or at least first 10 > > patches? Patches are now one month old and I have not touched this for > > that time period. Currently I have this code and details in my head, but > > chances are that I forgot other details in future and therefore it would > > be hard to me to again do needed analysis and later do required > > modifications. Prepare all those changes were time consuming, it took me > > half of year to evolve into V7 version and probably I would not have > > time to implement it again in future... > > I'll start reviewing them tomorrow. Sorry to everyone for my inactivity > lately... I see Georg gave some comments today in IRC about the first three patches: patch 1 is not needed, patch 2 looks good and about patch 3 there was some discussion about a seeming mismatch with BlueZ, but that turned out to not be a problem after all, so patch 3 should be good to go in as well. I'll continue review from patch 4 then. -- Tanu https://www.patreon.com/tanuk https://liberapay.com/tanuk _______________________________________________ pulseaudio-discuss mailing list pulseaudio-discuss@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss