Hongxu Jia <hongxu.jia@xxxxxxxxxxxxx>: > > While running pulseaudio out of build dir (especially for cross > compiling), we should not expose pulseaudio build path[1], it is > helpful for reproducibility build[2]. > > As commit introduced [3cae4a0 doc: Add info about running pulseaudio > from the build dir], run pulseaudio from the build dir, __OPTIMIZE__ > should be diabled, so add macro checking to drop PA_SRCDIR/PA_BUILDDIR > (in which contains build path) at precompilation. > > [1] https://reproducible-builds.org/docs/build-path/ > [2] https://reproducible-builds.org/ > > Signed-off-by: Hongxu Jia <hongxu.jia@xxxxxxxxxxxxx> I don't believe that the doc that you are basing your decisions on is correct. Anyway, basing such decisions automagically on the optimization level is very non-obvious. Maybe it is a better idea to introduce a special build flag (for autotools it would be something like --disable-running-from-build-tree or --enable-reproducible-build) that explicitly disables running from build tree and thus enables a reproducible build? -- Alexander E. Patrakov _______________________________________________ pulseaudio-discuss mailing list pulseaudio-discuss@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
