>> > > + bool avoid_resampling = s->core->avoid_resampling || s->avoid_resampling; >> > >> > Oh, this is how you planned to solve the "daemon.conf gets ignored" >> > problem. I think it's better to treat the daemon.conf option as a >> > default and override it with more fine-grained options, rather than >> > merging all options together. Your approach makes it impossible to >> > enable avoid-resampling by default and disabling it on per-card basis >> > (which is what I thought you wanted to do in the first place). >> >> Yes, as your comments, it is impossible to "enable avoid-resampling by default >> and disabling it on per-card basis". rather it is possible to "disable >> avoid-resampling >> by default and enabling on per-card basis". I think there is a different view. >> I'm willing to revise it as per your comment. But actually it is >> difficult to think the >> options to be treated all together in daemon.conf. Could you let me know some >> more advices on this? > > pa_alsa_sink_new() should set pa_sink_new_data.avoid_resampling to the > value of pa_core.avoid_resampling by default. If the avoid_resampling > module argument is in the module arguments, then pa_alsa_sink_new() > should set pa_sink_new_data.avoid_resampling to the module argument > value. > > When module-udev-detect loads module-alsa-card, it should set the > avoid_resampling module argument to the value of > pa_core.avoid_resampling by default. If the avoid_resampling module > argument is passed to module-udev-detect, then module-udev-detect > should pass that on to module-alsa-card. Okay, I've overlooked relation between value of default.conf and module argument. I'll revise it as well as the commit message. Regards, Sangchul
