constification round #4 (pa_mainloop_api) 26 patches in total. I attached a zipped copy also. The first 19 avoid (client) API change; the final 7 do not and will have to wait until ready and happy to do an API bump. I'm not certain if there's a public API for 3rd-party modules, but if so then I can anticipate issue being taken with respect to pa_iochannel_get_mainloop_api() in #14. Unpicking that though would not be so easy :/ It's possible for patches #21, #23 and #24 to be bumped down before the API change of #20, but as things are they are blocked by it and it would require a temporary hack... #23 and #24 (utils) depend upon pa_signal_init(), done in #21 which involves changing the underlying static; this depends upon changing pa_signal_destroy_cb_t (#20), because of the way pa_signal_free() works (passing that static api ref to the destroy callback which requires non-const). Getting around this would require injecting a temporary hack into pa_signal_free() giving alternate means of obtaining a non-const api pointer - i.e. api function pointer comparison would be necessary to tell us which mainloop is in use, to then get what we need using the correct *_get_api() with api->userdata. -------------- next part -------------- A non-text attachment was scrubbed... Name: 01.patch Type: text/x-patch Size: 1185 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0026.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 02.patch Type: text/x-patch Size: 1315 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0027.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 03.patch Type: text/x-patch Size: 2860 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0028.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 04.patch Type: text/x-patch Size: 2462 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0029.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 05.patch Type: text/x-patch Size: 1472 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0030.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 06.patch Type: text/x-patch Size: 15642 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0031.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 07.patch Type: text/x-patch Size: 17717 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0032.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 08.patch Type: text/x-patch Size: 1227 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0033.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 09.patch Type: text/x-patch Size: 4284 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0034.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 10.patch Type: text/x-patch Size: 2391 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0035.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 11.patch Type: text/x-patch Size: 547 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0036.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 12.patch Type: text/x-patch Size: 548 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0037.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 13.patch Type: text/x-patch Size: 2234 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0038.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 14.patch Type: text/x-patch Size: 26246 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0039.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 15.patch Type: text/x-patch Size: 7920 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0040.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 16.patch Type: text/x-patch Size: 1573 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0041.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 17.patch Type: text/x-patch Size: 581 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0042.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 18.patch Type: text/x-patch Size: 1651 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0043.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 19.patch Type: text/x-patch Size: 3494 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0044.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 20.patch Type: text/x-patch Size: 1109 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0045.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 21.patch Type: text/x-patch Size: 1557 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0046.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 22.patch Type: text/x-patch Size: 984 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0047.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 23.patch Type: text/x-patch Size: 593 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0048.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 24.patch Type: text/x-patch Size: 677 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0049.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 25.patch Type: text/x-patch Size: 4383 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0050.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: 26.patch Type: text/x-patch Size: 3586 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0051.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: const_round_4.zip Type: application/zip Size: 31868 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180628/3c44ac67/attachment-0001.zip>
