On Tue, 2018-06-26 at 12:15 +0300, Tanu Kaskinen wrote: > On Tue, 2018-06-19 at 17:39 +0100, jnqnfe at gmail.com wrote: > > On Mon, 2018-06-18 at 10:47 +0300, Tanu Kaskinen wrote: > > > Your patches are based on the view that setting the error code > > > isn't > > > considered mutating the context object. I think constifying > > > pa_context_set_error() is fully in line with that view. Or do you > > > think > > > that when the validation macros set the code, that's not mutating > > > the > > > context object, but when other code calls pa_context_set_error(), > > > that > > > is mutating the context object? > > > > Yes, the latter. > > > > > Anyway, I'll send the constification patch. > > > > Ok :) > > I applied my patch now, and the rest of your patches. Thanks for the > patches! Ok, no problem :)
