On Wed, Jun 27, 2018 at 2:19 PM Tanu Kaskinen <tanuk at iki.fi> wrote:
> Having a warning in the syslog should make it a bit easier to debug
> situations where some other program is hogging the sound card.
>
+1. Just the other day someone on IRC had this problem and debug logs were
needed.
> ---
> src/modules/module-udev-detect.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/modules/module-udev-detect.c
> b/src/modules/module-udev-detect.c
> index d119f96ae..4598a3d13 100644
> --- a/src/modules/module-udev-detect.c
> +++ b/src/modules/module-udev-detect.c
> @@ -308,7 +308,9 @@ static void verify_access(struct userdata *u, struct
> device *d) {
> * inotify and can then recheck. */
>
> busy = is_card_busy(path_get_card_id(d->path));
> - pa_log_debug("%s is busy: %s", d->path, pa_yes_no(busy));
> +
> + if (busy)
> + pa_log_warn(_("Can't use sound card %s, because some
> other program is using it."), d->card_name);
>
I think the path info is important because it is something that one can
then pass on to lsof.
>
> if (!busy) {
>
This should be an else, otherwise it's weird to have if (foo) {} if (!foo)
{} blocks.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180627/e88a0afc/attachment.html>
