The first patch is a reaction to a bug report[1] that pointed out a weird thing in the sink input drained state handling. I came to the conclusion that we can just remove the entire drained state. After removing the drained state, pa_sink_input_get_state() didn't have anything to do any more, except to just return the state variable. pa_source_output_get_state() didn't do anything either. The second patch removes those functions. Then I noticed that pa_sink_get_state() and pa_source_get_state() don't do anything either, so the third patch removes those as well. [1] https://bugs.freedesktop.org/show_bug.cgi?id=106982 Tanu Kaskinen (3): sink-input: remove the DRAINED state sink-input, source-output: remove the state getters sink, source: remove the state getters src/modules/alsa/alsa-sink.c | 2 +- src/modules/alsa/alsa-source.c | 2 +- src/modules/dbus/iface-device.c | 12 +++---- src/modules/echo-cancel/module-echo-cancel.c | 34 ++++++++++---------- src/modules/module-combine-sink.c | 16 ++++----- src/modules/module-device-manager.c | 4 +-- src/modules/module-equalizer-sink.c | 10 +++--- src/modules/module-intended-roles.c | 12 +++---- src/modules/module-ladspa-sink.c | 6 ++-- src/modules/module-loopback.c | 8 ++--- src/modules/module-remap-sink.c | 2 +- src/modules/module-remap-source.c | 4 +-- src/modules/module-rescue-streams.c | 4 +-- src/modules/module-stream-restore.c | 12 +++---- src/modules/module-suspend-on-idle.c | 22 +++++-------- src/modules/module-tunnel.c | 4 +-- src/modules/module-virtual-sink.c | 10 +++--- src/modules/module-virtual-source.c | 14 ++++---- src/modules/module-virtual-surround-sink.c | 10 +++--- src/modules/stream-interaction.c | 12 +++---- src/pulsecore/cli-command.c | 4 +-- src/pulsecore/cli-text.c | 9 +++--- src/pulsecore/core.c | 4 +-- src/pulsecore/protocol-esound.c | 7 ++-- src/pulsecore/protocol-native.c | 28 ++++++++-------- src/pulsecore/sink-input.c | 34 ++++---------------- src/pulsecore/sink-input.h | 9 +----- src/pulsecore/sink.c | 8 ++--- src/pulsecore/sink.h | 2 -- src/pulsecore/source-output.c | 10 +++--- src/pulsecore/source-output.h | 2 -- src/pulsecore/source.c | 10 ++---- src/pulsecore/source.h | 2 -- 33 files changed, 140 insertions(+), 189 deletions(-) -- 2.17.0
