[PATCH] alsa-mixer: make the mono mapping a fallback only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01.06.2018 10:24, Tanu Kaskinen wrote:
> If a sound card doesn't have the "front" device defined for it, we have
> to use the "hw" device for stereo. Not so long ago, the analog-stereo
> mapping had "hw:%f" in its device-strings and everything worked great,
> except that it caused trouble with the Intel HDMI LPE driver that uses
> the first "hw" device for HDMI, and we were incorrectly detecting it as
> an analog device. That problem was fixed in commit ea3ebd09, which
> removed "hw:%f" from analog-stereo and added a new stereo fallback
> mapping for "hw".
>
> Now the problem is that if a sound card doesn't have the "front" device
> defined for it, and it supports both mono and stereo, only the mono
> mapping is used, because the stereo mapping is only a fallback. This
> patch makes the mono mapping a fallback too, so the mono mapping is used
> only if there's absolutely nothing else that works.
>
> This can cause trouble at least in theory. Maybe someone actually wants
> to use mono output on a card that supports both mono and stereo. But
> that seems quite unlikely.
> ---
>   src/modules/alsa/alsa-mixer.c                  |  1 +
>   .../alsa/mixer/profile-sets/default.conf       | 18 ++++++++++--------
>   2 files changed, 11 insertions(+), 8 deletions(-)
>
Looks good to me. I don't mind having it in 12.0, but let Arun have
the last word.

BTW, when are we going to release 12.0? I have not heard any
complaints yet.


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux