Hi, On Mon, Aug 20, 2018 at 3:44 PM Sathish Narasimman <nsathish41 at gmail.com> wrote: > > On Mon, Aug 20, 2018 at 7:06 PM Ahmed S. Darwish <darwish.07 at gmail.com> wrote: >> >> On Mon, Aug 20, 2018 at 3:16 PM Sathish Narasimman <nsathish41 at gmail.com> wrote: >> > >> > hi, >> > >> > Sorry, I am getting confused here. the format I understood was >> > In the commit format, may I follow as below format. Please let me know if it is correct. If so, i will submit the v3 >> >> Please don't top-post: >> >> http://www.idallen.com/topposting.html >> >> > ------------------------------------------------------------------ >> > >> > bluetooth: wideband speech implementation >> > >> >> Yes, that would be the subject line. >> >> > From: Sathish Narasimman <sathish.narasimman at intel.com> >> > >> > mSBC-encoded streams for HFP. The wideband speec encoding and decoding >> > is implemeted with this patch. This patch was refered from original >> > patch of Joao Paula Rechi Vita and was verified with the supported >> > bluetooth controller. >> > >> > Signed-off-by: Sathish Narasimman <sathish.narasimman at intel.com> >> >> Yes, that would be the body, along with three dashes '---' after >> the S-o-b line. >> > > Thanks for the guide. I will submit v3 > So, these rules apply only if it is s-o-b? > > If so. It would be helpful if the PA link is updated . > https://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/ > These rules only apply because you're sending an employer-sponsored work (Intel) from a personal gmail account, which is not the common case -- no need to modify the wiki here. git-am assigns the commit author and commit title from the e-mail _headers_ "From: " and "Subject: " lines. But since we want the commit author (Intel) to be different from the _headers_ "From: " line (personal gmail), we override it in the body. >From git-am(1) manpage: The commit author name is taken from the "From: " line of the message, and commit author date is taken from the "Date: " line of the message. The "Subject: " line is used as the title of the commit, after stripping common prefix "[PATCH <anything>]". The "Subject: " line is supposed to concisely describe what the commit is about in one line of text. "From: " and "Subject: " lines starting the body override the respective commit author name and title values taken from the headers. Notice the last paragraph. Good luck, -- Darwish http://darwish.chasingpointers.com
