Hi, I had submitted the patch version 2 . please help to review the same On Thu, Aug 16, 2018 at 12:58 AM Georg Chini <georg at chini.tk> wrote: > On 15.08.2018 09:24, Pali Rohár wrote: > > On Wednesday 15 August 2018 09:24:04 Sathish Narasimman wrote: > >> Hi Pali, > >> > >> On Wed, Aug 15, 2018 at 1:31 AM, Pali Rohár <pali.rohar at gmail.com> > wrote: > >> > >>> On Tuesday 14 August 2018 22:49:27 Luiz Augusto von Dentz wrote: > >>>> Hi Pali, > >>>> > >>>> On Tue, Aug 14, 2018 at 10:28 PM Pali Rohár <pali.rohar at gmail.com> > >>> wrote: > >>>>> On Tuesday 14 August 2018 19:44:49 Sathish Narasimman wrote: > >>>>>> mSBC-encoded streams for HFP. The wideband speec encoding and > >>> decoding > >>>>>> is implemeted with this patch. This patch was refered from original > >>>>>> patch of Joao Paula Rechi Vita and was verified with the supported > >>>>>> bluetooth controller. > >>>>>> > >>>>>> Signed-off-by: Sathish Narasimman <sathish.narasimman at intel.com> > >>>>>> --- > >>>>>> src/modules/bluetooth/backend-ofono.c | 20 +- > >>>>>> src/modules/bluetooth/module-bluez5-device.c | 371 > >>> ++++++++++++++++++++++++++- > >>>>>> 2 files changed, 377 insertions(+), 14 deletions(-) > >>>>> Hi! This looks great. What about support also for other backends, not > >>>>> only ofono? > >>>> Afaik only oFono supports WBS negotiation. > >>> IIRC codec negotiation is done via AT commands. Therefore native > backend > >>> and its AT parser could be extended to support it. > >>> > >> AFAIK i was not able to find Handsfree profile in native backend. I see > >> only the headset profile in which codec negotiation is not available. > >> please point me the right place where AT commands are implented in PA > for > >> HFP profile in native backend. i can try the best. > > rfcomm_io_callback function in backend-native.c. There is implemented AT > > parser. For codec selection is needed to issue some AT command, > > therefore that code is needed to extend... > > > Currently there is no HFP support in the native backend. There have > been patches by James Bottomley to implement HFP, but they have > never been merged due to remaining issues. See here: > https://patchwork.freedesktop.org/series/30716/ > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20180817/d2d97525/attachment.html>
