On Sun, 2017-09-03 at 10:26 -0300, Felipe Sateler wrote: > I don't know enough to review this patch, but I notice an inconsistency. > > On Sep 2, 2017 09:39, "Tanu Kaskinen" <tanuk at iki.fi> wrote: > > This control has been seen in the wild: > https://lists.freedesktop.org/archives/pulseaudio-discuss/ > 2017-August/028595.html > (The pastebin link in that mail might not work anymore, but the paste > just shows that there's a Speaker Jack control). > --- > src/modules/alsa/mixer/paths/analog-output-speaker.conf | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/modules/alsa/mixer/paths/analog-output-speaker.conf > b/src/modules/alsa/mixer/paths/analog-output-speaker.conf > index 9f4dac414..6f9968e1f 100644 > --- a/src/modules/alsa/mixer/paths/analog-output-speaker.conf > +++ b/src/modules/alsa/mixer/paths/analog-output-speaker.conf > @@ -56,6 +56,9 @@ state.unplugged = unknown > state.plugged = no > state.unplugged = unknown > > +[Jack Speaker] > +required-any = any > + > > > The commit message and pastebin mention Speaker Jack, not Jack Speaker. This is because the configuration file uses this format for sections: [<type> <name>] Here the section type is "Jack" and the name is "Speaker". All jack controls in alsa have "Jack" at the end of their name (that's how PulseAudio recognizes that they are jack controls), so in this case the alsa control name is "Speaker Jack". We could write [Jack Speaker Jack] in the configuration file, but that would be ugly. -- Tanu https://www.patreon.com/tanuk
