On Fri, 2017-03-17 at 07:59 +0530, Arun Raghavan wrote: > The webrtc canceller seems to have changed to require that the > set_stream_drift_samples() method be called before every call of > ProcessStream(). > > So we now call ec->set_stream_drift_samples() before calling > ec->record() by: > > 1. Always calling do_push_drift_comp() instead of only when the sink is > running > > 2. Calling set_stream_drift_samples() in the loop with record() instead > of outside > > We do kind of leak this quirk of the webrtc canceller into the generic > bits of module-echo-cancel, but this should not be harmful in the > general case either. > --- > src/modules/echo-cancel/module-echo-cancel.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) Looks good to me. -- Tanu https://www.patreon.com/tanuk
