On 06.03.2017 08:43, Peter Meerwald-Stadler wrote: > the first patch commits the model file as used on scan.coverity.com > and rewrites pa_assert_se() so that Coverity doesn't complain about > side-effects > > some more Coverity fixes for the raop code > > Peter Meerwald-Stadler (10): > build: Add Coverity scan model > raop: Fix double free > raop: Fix loop searching for port number > raop: Fix memleak > raop: Fix resource leaks > raop: Fix potential memory leak > raop: Fix indentation > raop: Silence unchecked return value warnings > raop: Fix potential resource leaks > raop: Fix potential NULL dereference > > coverity/model.c | 18 ++++++++++++++ > src/modules/raop/module-raop-discover.c | 22 +++++++++++++---- > src/modules/raop/raop-client.c | 44 +++++++++++++++++---------------- > src/modules/raop/raop-sink.c | 6 ++--- > src/pulsecore/macro.h | 9 +++++++ > 5 files changed, 70 insertions(+), 29 deletions(-) > create mode 100644 coverity/model.c > All of them look good, except one small issue in patch 3.