On Tue, 2017-06-27 at 23:45 +0300, Luiz Augusto von Dentz wrote: > Hi Tanu, > > On Mon, Jun 19, 2017 at 4:43 PM, Tanu Kaskinen <tanuk at iki.fi> wrote: > > On Thu, 2017-05-25 at 11:36 +0300, Luiz Augusto von Dentz wrote: > > > From: Luiz Augusto von Dentz <luiz.von.dentz at intel.com> > > > > > > BlueZ 4 is no longer supported by BlueZ community for a long long time, > > > also by moving to BlueZ 5 it should make it even more clearer that > > > BlueZ 4 is no longer an option. > > > --- > > > configure.ac | 16 +- > > > po/POTFILES.in | 1 - > > > src/Makefile.am | 28 - > > > src/modules/bluetooth/bluez4-util.c | 1843 -------------- > > > src/modules/bluetooth/bluez4-util.h | 160 -- > > > src/modules/bluetooth/module-bluetooth-discover.c | 13 +- > > > src/modules/bluetooth/module-bluez4-device.c | 2657 --------------------- > > > src/modules/bluetooth/module-bluez4-discover.c | 188 -- > > > 8 files changed, 3 insertions(+), 4903 deletions(-) > > > delete mode 100644 src/modules/bluetooth/bluez4-util.c > > > delete mode 100644 src/modules/bluetooth/bluez4-util.h > > > delete mode 100644 src/modules/bluetooth/module-bluez4-device.c > > > delete mode 100644 src/modules/bluetooth/module-bluez4-discover.c > > > > > > > git grep -i "bluez 4" still returns some hits in module-bluetooth- > > policy.c. > > These I guess: > > src/modules/bluetooth/module-bluetooth-policy.c: /* TODO: remove > hfgw when we remove BlueZ 4 support */ > src/modules/bluetooth/module-bluetooth-policy.c: /* TODO: remove > hfgw when we remove BlueZ 4 support */ > src/modules/bluetooth/module-bluetooth-policy.c: /* TODO: remove > a2dp and hsp when we remove BlueZ 4 support */ > > Not sure if those comments make sense anymore since we do have hfgw > support in BlueZ 5, or perhaps it is referring to something else. The bluez5 code uses a bit different profile names than the bluez4 code, so module-bluetooth-policy had to deal with both. Now the references to the profile names that are only used by the bluez4 code can be removed. -- Tanu https://www.patreon.com/tanuk
