On Sun, 2017-08-27 at 22:48 +0200, Colin Leroy wrote: > On 27 August 2017 at 19h07, Colin Leroy wrote: > > Hi, > > > > The solution seems good to me. Just a couple of minor issues: > > > > Here's a patch addressing your remarks. I squashed the two commits in > > one for clarity. > > He, sorry, I changed the return code of two pa__init() functions by > mistake. Please add 0002-... to the previous one - or use 0001-...v2 > instead of the patch in the previous mail. Thanks! I applied the patch to the "next" branch with some modifications: even though the pa_error_code_t type exists, errors are still reported as unsigned ints. I also added some more explanation to the commit message. -- Tanu https://www.patreon.com/tanuk