[PATCH] x11-bell: ignore volume from X11

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2016-11-11 at 13:14 +0500, Alexander E. Patrakov wrote:
> On 11/10/2016 04:22 PM, Tanu Kaskinen wrote:
> > X11 has its own bell volume setting, controlled with the "xset b"
> > command. If we use that volume, then the "System Sounds" slider in
> > pavucontrol doesn't affect the x11-bell sample volume, which in my
> > opinion is a bad thing. Ignoring the volume suggestion from X11 allows
> > module-stream-restore to apply the "event" role volume.
> 
> Looks reasonable.
> 
> The alternative would be to synchronize the X11 bell volume and the 
> "event" role volume bidirectionally (so that "xset b" also sets the 
> "event" role volume). However, that would be a lot of new code 
> (XRecord?), and we don't know who else sets the X11 bell volume and 
> when, so let's use the simple solution of ignoring it.

Thanks for having a look. I pushed this to "next" now.

-- 
Tanu

https://www.patreon.com/tanuk


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux