On Mon, 2016-01-18 at 13:06 +0530, arun at accosted.net wrote:
> From: Arun Raghavan <git at arunraghavan.net>
>
> Just exposing this, disabled by default. It's not used by Chromium at
> the moment.
> ---
> Â src/modules/echo-cancel/webrtc.cc | 14 ++++++++++++--
> Â 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/src/modules/echo-cancel/webrtc.cc b/src/modules/echo-cancel/webrtc.cc
> index f4f1395..bbfa43f 100644
> --- a/src/modules/echo-cancel/webrtc.cc
> +++ b/src/modules/echo-cancel/webrtc.cc
> @@ -47,6 +47,7 @@ PA_C_DECL_END
> Â #define DEFAULT_COMFORT_NOISE true
> Â #define DEFAULT_DRIFT_COMPENSATION false
> Â #define DEFAULT_EXTENDED_FILTER false
> +#define DEFAULT_INTELLIGIBILITY_ENHANCER false
> Â
> Â static const char* const valid_modargs[] = {
> Â Â Â Â Â "high_pass_filter",
> @@ -58,6 +59,7 @@ static const char* const valid_modargs[] = {
> Â Â Â Â Â "comfort_noise",
> Â Â Â Â Â "drift_compensation",
> Â Â Â Â Â "extended_filter",
> +Â Â Â Â "intelligibility_enhancer",
> Â Â Â Â Â NULL
> Â };
> Â
> @@ -84,7 +86,7 @@ bool pa_webrtc_ec_init(pa_core *c, pa_echo_canceller *ec,
> Â Â Â Â Â webrtc::AudioProcessing *apm = NULL;
> Â Â Â Â Â webrtc::ProcessingConfig pconfig;
> Â Â Â Â Â webrtc::Config config;
> -Â Â Â Â bool hpf, ns, agc, dgc, mobile, cn, ext_filter;
> +Â Â Â Â bool hpf, ns, agc, dgc, mobile, cn, ext_filter, intelligibility;
> Â Â Â Â Â int rm = -1;
> Â Â Â Â Â pa_modargs *ma;
> Â
> @@ -163,8 +165,16 @@ bool pa_webrtc_ec_init(pa_core *c, pa_echo_canceller *ec,
> Â Â Â Â Â Â Â Â Â goto fail;
> Â Â Â Â Â }
> Â
> +Â Â Â Â intelligibility = DEFAULT_INTELLIGIBILITY_ENHANCER;
> +Â Â Â Â if (pa_modargs_get_value_boolean(ma, "intelligibility_enhancer", &intelligibility) < 0) {
> +Â Â Â Â Â Â Â Â pa_log("Failed to parse intelligibility_enhancer value");
> +Â Â Â Â Â Â Â Â goto fail;
> +Â Â Â Â }
> +
> Â Â Â Â Â if (ext_filter)
> Â Â Â Â Â Â Â Â Â config.Set(new webrtc::ExtendedFilter(true));
> +Â Â Â Â if (intelligibility)
> +Â Â Â Â Â Â Â Â config.Set<webrtc::Intelligibility>(new webrtc::Intelligibility(true));
The same comment as in the previous patch: could the if statement be
eliminated?
> Â
> Â Â Â Â Â apm = webrtc::AudioProcessing::Create(config);
> Â
> @@ -253,7 +263,7 @@ void pa_webrtc_ec_play(pa_echo_canceller *ec, const uint8_t *play) {
> Â Â Â Â Â pa_assert(play_frame.samples_per_channel_ <= webrtc::AudioFrame::kMaxDataSizeSamples);
> Â Â Â Â Â memcpy(play_frame.data_, play, ec->params.priv.webrtc.blocksize);
> Â
> -Â Â Â Â apm->AnalyzeReverseStream(&play_frame);
> +Â Â Â Â apm->ProcessReverseStream(&play_frame);
This looks like a potentially unrelated change. Why is this change
done?
--Â
Tanu
