-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 18.01.2016 05:21, Arun Raghavan wrote: > On Fri, 2016-01-15 at 14:33 +0100, Kamil Rytarowski wrote: >> On 12.01.2016 04:08, Arun Raghavan wrote: >>> On 11 January 2016 at 19:37, David Henningsson >>> <david.henningsson at canonical.com> wrote: >>>> Hi, >>>> >>>> this patch seems to need further explanation. >>>> >>>> I e, what "newer API", and why have we added a set_mute call >>>> in some places after get_mute and not others? >>> >>> Probably just needs to reference commit >>> e4a7625ba884c5cce20468d75937857343751c35 >>> >>> http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=e4a762 >>> >>> 5ba >> 884c5cce20468d75937857343751c35 >>> >>> >> Is there still need to improve the patch? > > Not really, though I think I'd prefer to exchange the author and > attribution (i.e. Jonathan as author, and your contribution > mentioned in the commit message). I'll fix that up and mention the > earlier commit if there are no objections. Well, Jonathan's added original patches to pkgsrc regarding this platform. SunOS 1/2 is unmodified his work. SunOS 2/2 was reworked by myself, I changed the code from #ifdef __sunos #endif to autoconf checks. I'm OK with your proposal as long as it will be merged and delta between pkgsrc and upstream reduced. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWnI6TAAoJEEuzCOmwLnZsNCsP/3q1QsNUHK9y+w9/kyjzLeRo 88D/7CFHClkkjdTVYnwXoAcIuPp1QUXfmQzvOX/z0NK6mw57U6IWsfChBptE/aHl /hkFFA9AVks2vpIcBp1HgqYUHCBcbFu/AfrL/8zCaOejWhk6Vy8u6lzG1fThOfKz 3FIpTjimuP3D1LalIFAPJv6WMC4T+oHJUvE5OuduEFWrcLFSHdVMX4QzvMKwOsaN 3qBTUGxKymUNg+gVEx8vRlU335ffgttgNGcW6ZJD2QJ+Em9R8JAfBb396E1sRPVi faBf3RTwYuo5+evGeeF3Odgx9pwv3i5RDSo6j3Eg1VHCUBRXjkqCc3Bj5ulOHiRl fyLyqceezz1fE0+I5BwU6Re+bs4r4OrXFGmPUWM1PXn0E/GlLUaOW99CgSR9Wh8B oLtdH3g66vOSSFwh2Oz02/AhdGSa9ztm/DStezz2/kRK+gRyoG80q6ty3Ii45+VG 52MwxZdd6nX2t44uycFwrPMdp/uVDBvhyQ0dEkEr0fUV8oxdaZDQfUik7zOU4jjs GGan8oDcQzxd1DsjHcpCyNZBqQBqjZWyvU2eHSoTZlclaePw9Rn2YrO05VR3Z3IW nV5riGPNK7aYZLDewY2saArd4Isa//yey/zNd8L+iTNZJk9eit4W4CF6KRnB/253 nBF5cc//Rz7DyDQx9a/K =RPVC -----END PGP SIGNATURE-----
