[PATCH v3 07/24] echo-cancel: Add a modarg to use sink/source master format and spec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-02-02 at 09:56 +0530, Arun Raghavan wrote:
> On Thu, 2016-01-28 at 09:40 +0200, Tanu Kaskinen wrote:
> > On Mon, 2016-01-18 at 13:06 +0530, arun at accosted.net wrote:
> > > From: Arun Raghavan <git at arunraghavan.net>
> > > 
> > > This allows us to inherit the sample spec parameters from the sink
> > > and
> > > source master (rather than forcing 32 kHz / mono). It is still
> > > possible
> > > to override some of the parameters for the source side with
> > > modargs.
> > 
> > What reasons do you see for using or not using parameters from the
> > master devices? Should use_master_format perhaps be enabled by
> > default?
> 
> My original testing showed that these parameters provided a decent
> perf/quality trade-off on lower end hardware (which I no longer have
> access to). I figure it makes sense to continue with that for now, and
> in the future this can be relaxed (use_master_format=yes could be the
> default, and resource-constrained systems can disable it).

Ok. Worth mentioning in the commit message.

-- 
Tanu


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux