On Sun, 2015-09-20 at 23:32 +0200, Ahmed S. Darwish wrote: > diff --git a/src/pulsecore/mem.h b/src/pulsecore/mem.h > index 7390e47..e5a9ec3 100644 > --- a/src/pulsecore/mem.h > +++ b/src/pulsecore/mem.h > @@ -40,4 +44,14 @@ typedef struct pa_mem { > __PA_PARENT_MEM_STRUCT__; > } pa_mem; > > + > +/* > + * Some methods and definitions commonly used by our children > + */ > + > +#define MAX_SHARED_MEM_SIZE (PA_ALIGN(1024*1024*1024)) Should have PA_ prefix. > + > +int shared_fd_get_file_size(int fd, size_t *size); Should have pa_ prefix. > +void pa_mem_punch_region(pa_mem *shm_area, size_t punch_offset, size_t punch_size); This is a good opportunity to add some documentation about what the function does :) Yesterday I had to figure out what vacuuming means, and comments somewhere whould have been helpful... -- Tanu