[PATCH v2 0/7] Save/restore profile per port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2015-10-29 12:49, Tanu Kaskinen wrote:
> On Tue, 2015-10-27 at 16:09 +0100, David Henningsson wrote:
>> Changes since v1:
>>    * Rebased to master (thanks Tanu)
>>    * Added pa_device_port_set_preferred_profile
>>    * pa_card_set_profile now updates preferred profile, instead
>>      of module-card-restore
>>      (to make Tanu happy - if it was up to me, I probably would have kept
>>      it as it was)
>
> If the preferred_profile semantics are module-dependent, then the
> variable doesn't belong in the core. If you want to make module-card-
> restore or some other module the "owner" of the semantics that are
> implemented in this patch set, I'm fine with that, but then the
> variable needs to move to some non-core API.

preferred_profile means "the profile that this port prefers", so there's 
no module dependency in the semantics.

But exactly how to determine what profile a port prefers, that's 
something that could benefit from being module dependent.

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux