On 4 November 2015 at 18:10, Felipe Sateler <fsateler at debian.org> wrote: > On 4 November 2015 at 09:14, <arun at accosted.net> wrote: >> From: Arun Raghavan <git at arunraghavan.net> >> >> --- >> src/modules/echo-cancel/webrtc.cc | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/src/modules/echo-cancel/webrtc.cc b/src/modules/echo-cancel/webrtc.cc >> index 3be7fe5..a8b69b5 100644 >> --- a/src/modules/echo-cancel/webrtc.cc >> +++ b/src/modules/echo-cancel/webrtc.cc >> @@ -78,9 +78,9 @@ static int routing_mode_from_string(const char *rmode) { >> return -1; >> } >> >> -void pa_webrtc_ec_fixate_spec(pa_sample_spec *rec_ss, pa_channel_map *rec_map, >> - pa_sample_spec *play_ss, pa_channel_map *play_map, >> - pa_sample_spec *out_ss, pa_channel_map *out_map) >> +static void pa_webrtc_ec_fixate_spec(pa_sample_spec *rec_ss, pa_channel_map *rec_map, >> + pa_sample_spec *play_ss, pa_channel_map *play_map, >> + pa_sample_spec *out_ss, pa_channel_map *out_map) > > Isn't the convention that static methods do not have pa_ prefix? It is, but the speex code is written like this too, so I left it there for consistency. -- Arun