[PATCH 3/3] pstream: Remove unnecessary if condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2015-03-05 at 14:55 +0100, David Henningsson wrote:
> +            if (!(b = pa_memimport_get(p->import,
> +                                      ntohl(re->shm_info[PA_PSTREAM_SHM_BLOCKID]),
> +                                      ntohl(re->shm_info[PA_PSTREAM_SHM_SHMID]),
> +                                      ntohl(re->shm_info[PA_PSTREAM_SHM_INDEX]),
> +                                      ntohl(re->shm_info[PA_PSTREAM_SHM_LENGTH]),
> +                                      !!(flags & PA_FLAG_SHMWRITABLE)))) {

While at it, you could fix the code formatting. The wrapped lines should
start at the same column as "p->import" on the first line.

Otherwise this looks good, and ack for patch 2 too.

-- 
Tanu



[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux