On Sun, 2014-09-21 at 16:28 +0600, Alexander E. Patrakov wrote: > 21.09.2014 16:19, Tanu Kaskinen wrote: > > Patch review status updated: > > http://www.freedesktop.org/wiki/Software/PulseAudio/PatchStatus/ > > "Reduce hardware pointer update syscalls" is not exactly "waiting for > review". I have tested it and found it to fail an assertion when the > sink is autosuspended. Also I did some profiling using perf, but testing > on one card does not give enough justification to reject the patch on > the "no performance improvement" basis. It does look like a valid > cleanup and simplification attempt, though. > > Of course this cannot count as a proper review, but, due to the failed > assertion, the need for a new version of the patch is quite obvious at > this point. You're right, due to the assertion crash a new version is definitely needed. I didn't think that properly through when I was thinking how to classify the patch (I tend to put patches to the "need review" section if I'm a bit unsure). Thanks for pointing this out! -- Tanu
