Hello Colin ! On Tue, 2014-09-16 at 18:53 +0200, Colin Leroy wrote: > On 16 September 2014 at 12h09, Martin Blanchard wrote: > > Hi, > > > > > I think the big items right now are: > > > > - merge Martin's patch into the tree > > > > > > OK, could you send it to me, Martin ? > > > > > > > Done. Please let me know if you have difficulties rebasing this on top > > of 5.0. > > I've rebased everything to my branch, it seems to work fine for me. > > I have added a commit that fixes the sink getting destroyed after > being set idle: first a PA_SINK_MESSAGE_SET_STATE/PA_SINK_IDLE message > is received, which disables the rtpoll; then, seconds later, a > PA_SINK_MESSAGE_SET_RAOP_STATE/PA_RAOP_DISCONNECTED is received after > the connection with the device is torn down, and as the thread state is > IDLE a module unload request was fired. > > I'm unsure if my patch is good. I've attached it to have your opinion... After a quick look, I would say the patch is good. Anyway I'm a bit confused about why this could happened... I have no RAOP device/server to investigate it at the time, I'll do some more testing next week. > The result of your patchset rebase is in > https://github.com/colinleroy/pulseaudio > > _______________________________________________ > pulseaudio-discuss mailing list > pulseaudio-discuss at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20140917/2dec5be7/attachment.sig>