[PATCH] daemon: Stop session-started PA daemon when exiting X session

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2014-09-16 19:39, Felipe Sateler wrote:
> On Tue, Sep 16, 2014 at 11:32 AM, David Henningsson
> <david.henningsson at canonical.com> wrote:
>>
>>
>> On 2014-09-16 15:09, Tanu Kaskinen wrote:
>>>
>>> On Tue, 2014-09-16 at 14:27 +0200, David Henningsson wrote:

>>>> Second, for ALSA and the mute issue, I think we need to notify PA
>>>> somehow that the system is going down, either for suspend, hibernate or
>>>> poweroff. And that needs to complete before ALSA mutes things. This has
>>>> nothing to do with X sessions.
>>>
>>>
>>> Does ALSA do the muting also when suspending or hibernating? I haven't
>>> noticed such behaviour, but then again, I haven't noticed the poweroff
>>> muting either...
>>
>>
>> Felipe, could you elaborate on this? I think I've seen such a mute script,
>> but I'm not sure if it was upstream or debian specific, perhaps it's even
>> removed these days?
>
> I was never able to reproduce. Unfortunately, the diagnosis is quite
> old, so I don't know if something changed that might have fixed the
> problem.
>
> The original report is here[1]. This patch comes originally from
> another bug report[2], which mentions another two bugs[3][4].
>
> As you can see, all of the reports are fairly old, so I'm not sure if
> anything has changed in this regard.
>
> The alsa shutdown script was a debian thing, apparently[5]. However
> alsa-utils upstream now includes systemd service files[6]. The two do
> not seem to be functionally equivalent, so perhaps the debian specific
> sysvinit script was problematic.
>
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=556971
> [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594001
> [3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=593746
> [4] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=593952
> [5] http://sources.debian.net/src/alsa-utils/1.0.28-1/debian/init/
> [6] http://sources.debian.net/src/alsa-utils/1.0.28-1/alsactl/

Thanks for looking it up. I think that since the mute script is a Debian 
specific thing, it should either be removed (preferrable), or Debian 
needs to make sure no PA instance is running before the script is executed.

If removing the mute script causes pops and clicks on shutdown or 
suspend (I suppose that's the reason it was added in the first place), 
then this should be reported as kernel bugs instead.

The upstream SystemD scripts (or Ubuntu upstart scripts) seems not to 
include any muting.

The $XAUTHORITY bug (your [3]) is interesting though. I can't find any 
reference to "XAUTHORITY" specifically in the code, but 
start-pulseaudio-x11 loads a bunch of modules, maybe it should also 
unload those modules when x11 quits?


-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux