[PATCH] Added module-ofono-switch-on-voicecall

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-03-24 at 14:32 -0700, Felipe Tonello wrote:
> On Mon, Mar 24, 2014 at 1:18 AM, Tanu Kaskinen
> > Why does this module have to be loaded before module-syspend-on-idle?
> > Such load order restrictions should be avoided if at all possible.
> 
> IIRC this was necessary because the sink/source new callback from this
> module had to be called first then the one from
> module-suspend-on-idle. Does it make sense?

Not really. You're using different hooks than module-suspend-on-idle, so
the module loading order has no effect on the order of the callbacks.

This "prevent idle suspending" logic doesn't really belong to this
module anyway, because this module is a policy module, but the "don't
suspend on idle" property is part of the device, not part of the policy,
in my opinion. Ideally the device would set the property by itself. Is
it possible for you to set the property as part of the device
configuration? Do you use static configuration in default.pa or UCM or
path configuration files?

-- 
Tanu



[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux