2014-03-08 7:34 GMT+06:00 David Henningsson <david.henningsson at canonical.com>: > On 03/07/2014 08:43 PM, Alexander E. Patrakov wrote: >> Yes, I understand that it is generally a bad idea (and rude) to destroy >> other people's contributions. But in this case, I think it is justified, >> as enough time has passed and people only added FIXMEs instead of fixing >> this (unfixable except by a full rewrite?) module. >> >> Note: I cannot promise to submit a better replacement module. >> >> --------------------8<------------------------- >> Module-equalizer-sink is horrible both from the DSP viewpoint and from >> C code viewpoint. Here is an incomplete list of what is wrong with it. > > I don't know how useful the module-equalizer-sink is today in practice, > but even if it is completely unusable, a first step should not be to > remove the code, but to stop building it by default. Then make a release > and see how many people complain. Hopefully one of the complaining > people will take up the torch and improve the module. > If it is usable even though the limitations you talk about, a warning in > the PulseAudio log would be more accurate. The module is "somewhat usable" for music. But even then, strictly speaking, it gives incorrect output (see point 2) for anything but flat frequency response curve. I will send a patch that whines if one attempts to build or use the module, implementing both your suggestions. Yes, this is just one more "FIXME" (and thus falls under the criticism in my initial mail), but at least it is a user-visible one. -- Alexander E. Patrakov
