[PATCH] client-conf: fix include of client-conf-x11.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2014-06-26 at 18:08 +0200, Alexander Couzens wrote:
> Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
> ---
>  src/pulse/client-conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/pulse/client-conf.c b/src/pulse/client-conf.c
> index 317c9f9..35c5532 100644
> --- a/src/pulse/client-conf.c
> +++ b/src/pulse/client-conf.c
> @@ -41,7 +41,7 @@
>  #include "client-conf.h"
>  
>  #ifdef HAVE_X11
> -#include <client-conf-x11.h>
> +#include "client-conf-x11.h"
>  #endif
>  
>  #define DEFAULT_CLIENT_CONFIG_FILE PA_DEFAULT_CONFIG_DIR PA_PATH_SEP "client.conf"

Thanks for the patch! However, a fix was submitted via bugzilla too[1],
and I applied that other patch, because I think the include should be
<pulse/client-conf-x11.h> like in the other patch, because the "foo.h"
include style should only be used by code that implements the foo.h API
(in this case that would be client-conf-x11.c, not client-conf.c).

[1] https://bugs.freedesktop.org/show_bug.cgi?id=80570

-- 
Tanu



[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux