Hi Javier, Sorry for very late response. The first two patches are good, I'll push them in a moment, but I have some comments about this third one. On Sat, 2013-10-26 at 23:26 +0100, Javier Jard?n wrote: > --- The commit message is missing explanation for why this patch is needed. > Makefile.am | 1 + > po/Makevars | 41 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 42 insertions(+) > create mode 100644 po/Makevars > > diff --git a/Makefile.am b/Makefile.am > index b0b2553..7774ed9 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -23,6 +23,7 @@ EXTRA_DIST = \ > LICENSE \ > GPL \ > LGPL \ > + build-aux/config.rpath \ This doesn't seem to be related to po/Makevars in any way, so it should be in a separate patch. Also, I don't know why config.rpath should be shipped in the tarball (I don't know/remember what config.rpath does, so I'm not saying that it shouldn't be shipped either). > doxygen/Makefile.am \ > doxygen/Makefile.in \ > doxygen/doxygen.conf.in \ > diff --git a/po/Makevars b/po/Makevars > new file mode 100644 > index 0000000..32692ab > --- /dev/null > +++ b/po/Makevars > @@ -0,0 +1,41 @@ > +# Makefile variables for PO directory in any package using GNU gettext. > + > +# Usually the message domain is the same as the package name. > +DOMAIN = $(PACKAGE) > + > +# These two variables depend on the location of this directory. > +subdir = po > +top_builddir = .. > + > +# These options get passed to xgettext. > +XGETTEXT_OPTIONS = --keyword=_ --keyword=N_ > + > +# This is the copyright holder that gets inserted into the header of the > +# $(DOMAIN).pot file. Set this to the copyright holder of the surrounding > +# package. (Note that the msgstr strings, extracted from the package's > +# sources, belong to the copyright holder of the package.) Translators are > +# expected to transfer the copyright for their translations to this person > +# or entity, or to disclaim their copyright. The empty string stands for > +# the public domain; in this case the translators are expected to disclaim > +# their copyright. > +COPYRIGHT_HOLDER = Free Software Foundation, Inc. Wrong copyright holder. I suppose it should be "PulseAudio contributors" or something like that. -- Tanu
