On Tue, 2014-05-27 at 21:37 +0200, Wim Taymans wrote: > Add the output from its sink-input attached callback and remove it > again from the detach callback. This simplifies some output_enable > and we can also avoid posting 2 messages for the sink. > --- > src/modules/module-combine-sink.c | 27 +++++++++++---------------- > 1 file changed, 11 insertions(+), 16 deletions(-) Thanks, this is a very good patch. I think it fixes some (theoretical?) race conditions too. Now the combine sink can never use detached sink inputs in its calculations, which is good. -- Tanu