On Fri, 2014-05-30 at 20:54 +0600, Alexander E. Patrakov wrote: > 30.05.2014 18:43, Tanu Kaskinen ?????: > > Hmm, it seems that the sink clock source in the patch is the wall clock. > > This seems to defeat the whole point of a custom sink, because you could > > as well load module-null-sink and record from its monitor in XRDP using > > libpulse. I thought the reason why a special XRDP sink is needed is that > > we want to use the client sound card as the clock source, thus avoiding > > the need to resample between two clock domains. > > Indeed, RTP, in any form, unconditionally forces one to use the local > clock source and add an adaptive resampler on the receiving end. A > rather complex solution, I'd say. > > But I don't agree that the ability to use the existing RTP modules would > defeat the whole point of the patch. Nice sink names in pavucontrol are > definitely a benefit, and that's why it is definitely a good idea, > independently from any xrdp-related stuff, to implement a real RTP sink > and source, not needing the null-sink trickery. I was actually talking about the custom xrdp protocol in that paragraph, not RTP, sorry for being unclear. -- Tanu
