On Fri, 2013-12-20 at 21:39 +0600, Alexander E. Patrakov wrote: > Tanu Kaskinen wrote: > > This is the only bit that I'd change in some way: > > > + * is too high. With flat volumes disabled (the default in Ubuntu), it > > > means + * the maximum hardware volume attenuated by the sink volume. In > > > most cases, + * this is appropriate. > > There is one more place where I would like to suggest a change. > > + * Note: there is a user-controllable slider in mixer applications such as > + * pavucontrol corresponding to each of the created streams. Also the server > + * supports only a limited number of simultaneous streams. Because of this, > + * it is not always appropriate to create multiple streams in one application > + * that needs to output multiple sounds. The rough guideline is: if there is > + * no use case that would require separate user-initiated volume changes for > + * each stream, perform the mixing inside the application. > > I would like to add the following after the first sentence: "Multiple > (especially identically named) volume sliders for the same application might > confuse the user". However, I don't insist - please use your own judgement > whether to add this. I added your change, the patch is now applied. Thanks! -- Tanu
