On Mon, 2014-12-29 at 20:10 +0500, Alexander E. Patrakov wrote: > 03.11.2014 14:47, Tanu Kaskinen wrote: > > An assertion was already used in pa_socket_server_new_unix(), this > > makes the TCP variants consistent with that. > > > > Even if pa_socket_server_new() could fail, the error handling wasn't > > good, because there was no "goto fail", meaning that the fd would have > > been leaked. > > The patch looks OK. Thanks for the review, I pushed the patch now (to the "next" branch). > However, the pa_socket_server_new() function is only > used in the same file, so maybe it is a good idea to also make it static? I agree. If you want to make that change happen soon, you'll have to write the patch yourself, though :) -- Tanu
