[PATCH 1/2] Warn on loading module-equalizer-sink

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks, pushed this one. I'll let Tanu answer for the other one.

On 2014-12-04 16:34, Alexander E. Patrakov wrote:
> See objections to the code in this email:
>
> http://lists.freedesktop.org/archives/pulseaudio-discuss/2014-March/020174.html
> Signed-off-by: Alexander E. Patrakov <patrakov at gmail.com>
> ---
>   src/modules/module-equalizer-sink.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/src/modules/module-equalizer-sink.c b/src/modules/module-equalizer-sink.c
> index 811bbc2..ce5f8c1 100644
> --- a/src/modules/module-equalizer-sink.c
> +++ b/src/modules/module-equalizer-sink.c
> @@ -1096,6 +1096,10 @@ int pa__init(pa_module*m) {
>
>       pa_assert(m);
>
> +    pa_log_warn("module-equalizer-sink is currently unsupported, and can sometimes cause "
> +                "PulseAudio crashes, increased latency or audible artifacts.");
> +    pa_log_warn("If you're facing audio problems, try unloading this module as a potential workaround.");
> +
>       if (!(ma = pa_modargs_new(m->argument, valid_modargs))) {
>           pa_log("Failed to parse module arguments.");
>           goto fail;
>

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux