On 2014-12-05 15:31, Tanu Kaskinen wrote: > On Fri, 2014-12-05 at 16:22 +0200, Tanu Kaskinen wrote: >> On Fri, 2014-12-05 at 15:00 +0100, David Henningsson wrote: >>> >>> On 2014-12-04 19:44, Tanu Kaskinen wrote: >>>> When using PulseAudio in system mode, it may be interesting to know >>>> which seats the devices are assigned to. This will be used in the >>>> tunnel manager to filter out the devices that belong to other users. >>> >>> I'd prefer if PA_PROP_UDEV_SEAT was called PA_PROP_DEVICE_SEAT, because >>> the seat a device belongs to could be generically useful to e g volume >>> control clients. >> >> If we make the seat id field non-udev specific, I'm happy with that. >> However, in that case I'd prefer to use a separate field in the >> appropriate structs instead of using proplists. As I've explained >> before, I don't like using proplists for stable core APIs. > > Or we could just define PA_PROP_UDEV_SEAT in proplist.h. It might not be > a good idea after all to pretend that the id isn't udev-specific. Ok. I guess if it's called PA_PROP_UDEV_SEAT, then it's also okay to fall back to "seat0", if that's what udev mandates. > I'm > not familiar with any other systems than udev that would implement the > seat concept. If there are (or will be in future) other systems with a > seat concept, we have no guarantee that seats in those systems can be > identified by simple strings, so keeping this udev specific seems like > the best approach to me. > -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic
