On Mon, Dec 1, 2014 at 8:18 AM, David Henningsson
<david.henningsson at canonical.com> wrote:
>
>
> On 2014-11-29 20:49, Felipe Sateler wrote:
>>
>> On Fri, Nov 21, 2014 at 12:05 PM, David Henningsson
>> <david.henningsson at canonical.com> wrote:
>>>
>>> Hi!
>>>
>>> PulseAudio 6.0 rc1 has now been released - compared to 5.0, we have over
>>> 300
>>> patches contributed by 41 people, and that's just the tip of the iceberg.
>>> All the millions of you who are using it, discussing it with your friends
>>> or
>>> random people who are wrong on the Internet [1], reporting bugs,
>>> answering
>>> questions on support forums, IRC channels, Facebook etc, or in other ways
>>> have been caring for PulseAudio, you have all helped shape PulseAudio
>>> what
>>> it is today. Thank you!
>>>
>>> Some of the new features include:
>>>
>>> * Bluez 5 HSP (headset profile) support, both with and without oFono
>>> * SystemD socket activation support
>>> * Better support for multichannel and 2.1 profiles
>>> * Protocol optimisations
>>
>>
>> I believe this line includes the srbchannel api.
>> The srbchannel test fails on freebsd with a sigsev, because the test
>> does not check that srbchannel_new succeeds before using it.
>>
>> Maybe the srbchannel test should be disabled when eventfd is not present?
>
>
> The srbchannel test should fail if the srbchannel is not available, so I
> think it makes most sense to disable it on architectures without
> srbchannels.
>
> Would you mind writing a patch for that? I'm a little unsure exactly when to
> disable it (given the different FreeBSD variants).
AFAIK, eventfd is a linux-only feature. But srbchannel relies on
eventfd, so we do not need to check for a given OS in the test, but
rather to the availability of eventfd:
diff --git a/src/tests/srbchannel-test.c b/src/tests/srbchannel-test.c
index ce5930b..1c347b2 100644
--- a/src/tests/srbchannel-test.c
+++ b/src/tests/srbchannel-test.c
@@ -99,6 +99,7 @@ START_TEST (srbchannel_test) {
pa_log_debug("And now the same thing with srbchannel...");
sr1 = pa_srbchannel_new(pa_mainloop_get_api(ml), mp);
+#ifdef HAVE_SYS_EVENTFD_H
pa_srbchannel_export(sr1, &srt);
pa_pstream_set_srbchannel(p1, sr1);
sr2 = pa_srbchannel_new_from_template(pa_mainloop_get_api(ml), &srt);
@@ -106,6 +107,9 @@ START_TEST (srbchannel_test) {
packet_test(250, 5, ml, p1, p2);
packet_test(10, 1234567, ml, p1, p2);
+#else
+ fail_unless(sr1 == NULL);
+#endif
pa_pstream_unref(p1);
pa_pstream_unref(p2);
--
Saludos,
Felipe Sateler
