On 2014-08-19 12:09, Tanu Kaskinen wrote: > On Tue, 2014-08-19 at 07:47 +0200, David Henningsson wrote: >> >> On 2014-08-17 13:52, Tanu Kaskinen wrote: >>> The analog-output path should be suppressed when there are more >>> specific paths available. Currently that usually doesn't happen. The >>> suppression can be done with the path subset detection, and this patch >>> makes that work (another approach would be to mark the elements as >>> required-absent, like analog-input does, but I like the subset >>> suppression more, because it requires less stuff in the configuration >>> files). The problem with listing the now-removed elements in >>> analog-output.conf was that if the sound card had e.g. a Speaker >>> element, then the switch behaviour was different between analog-output >>> and analog-output-speakers, so analog-output was not considered a >>> subset of analog-output-speakers. >> >> Removing the "Jack" ones should be okay, because they're required-any in >> lineout.conf, so if these elements exist, there is always a "Line Out". >> >> I'm not sure about removing the elements. Could there be hardware where >> we don't have anything making analog-output-speaker.conf show up, and we >> still want the control over the things you remove below in >> analog-output.conf? > > Could you be more specific? If there's nothing that makes > analog-output-speaker show up, then which of these do you think we might > want to control in analog-output: "Line HP Swap", Apparently added by myself in 2011, for a reason (needed by Dove boards). So removing this one will regress that board. This one is quite unusual so I bet keeping it wouldn't cause any unnecessary duplicates I think. > "Headphone", > "Headphone2", Arun changed the behaviour of these in 2013, before they behaved the same. I'm not really sure what to do here. It seems reasonable to keep them enabled for analog-output and muted for analog-output-speaker. > "Desktop Speaker"? AFAICR, I've never seen "Desktop Speaker". I think we can synchronise the behavior so that it is the same on "analog-output" and "analog-output-speaker". -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic
