26.04.2014 14:44, Peter Meerwald wrote: > Hello Alexander, >> On the same topic, in patch 09/11, you use the same pa_do_remap_func_t type >> for func_s16 and func_float in the pa_set_remap_func prototype. This leads to >> typecasts in callers such as init_remap_c(). Maybe it would be better to >> introduce different types for function pointers for the s16 and float cases? > > at some point a type cast has to happen; > probably the function implementation should have non-void pointer types, > and the function pointer expose void pointers? > let's stick to that I agree that a typecast has to happen, because in the end there are two situations where functions with different prototypes are assigned to m->do_remap. My own preference would be to make sure that all such typecasts are in pa_set_remap_func. And sorry, I still have not looked at patches 10 and 11 as thoroughly as I wanted, and I did no runtime testing. -- Alexander E. Patrakov
