Hi Tanu,
2014-04-17 9:42 GMT+02:00 Tanu Kaskinen <tanu.kaskinen at linux.intel.com>:
> On Thu, 2014-04-10 at 13:16 +0200, B?lint R?czey wrote:
>> Hi Tanu,
>>
>> 2014-04-10 13:08 GMT+02:00 Tanu Kaskinen <tanu.kaskinen at linux.intel.com>:
>> > On Thu, 2014-04-10 at 12:53 +0200, B?lint R?czey wrote:
>> >> Hi,
>> >>
>> >> Is there anything I could do to help the inclusion of the mentioned patch?
>> >
>> > Not at this point, the patch is just waiting for some maintainer to take
>> > a look. Sorry for taking so long. I should have time for it this or next
>> > week.
>> Thanks in advance. We are trying to clean up PulseAudio the bugs [1] in Debian's
>> bug tracker so I'll probably send a few more patches.
>
> I took a look at the original discussion thread[1] and it looks like I
> reviewed the patch, and had some complaints, and there was some
> follow-up discussion that stopped before reaching conclusion (my fault).
> The proposed interface in the last message[2] seems dubious, because it
> sets defaults that probably shouldn't have defaults. The C API doesn't
> have defaults either.
Thank you for looking at the original discussion. Honestly this is the
first Vala code I have ever seen, but to me it seems that default
values are already used in libpulse.vapi:
...
[CCode (cname="pa_channel_map_init_extend")]
public unowned ChannelMap? init_extend(uint8 channels,
ChannelMapDef def = ChannelMapDef.DEFAULT);
...
Since the proposed patch wraps the "simple" API i think it would be
reasonable to keep it as simple as a language allows, thus using
default values in Vala seems to be a good choice.
Thanks,
Balint
>
> [1] http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/12441
> [2] http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/12441/focus=14016
>
> --
> Tanu
>
