On Wed, 2013-10-02 at 09:35 +0200, Anton Lundin wrote: > On 28 September, 2013 - Arun Raghavan wrote: > > > On Wed, 2013-09-18 at 16:22 +0200, Anton Lundin wrote: > > > Signed-off-by: Anton Lundin <glance at acc.umu.se> > > > --- > > > src/daemon/main.c | 2 +- > > > src/pulsecore/core-util.c | 8 ++++---- > > > src/pulsecore/rtkit.c | 2 +- > > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > Thanks, I've had a similar patch sitting in my tree for a bit. > > > > [...] > > > -#ifndef OS_IS_WIN32 > > > +#if !defined(OS_IS_WIN32) && !defined(__ANDROID__) > > > if (!S_ISDIR(st.st_mode) || > > > (st.st_uid != uid) || > > > (st.st_gid != gid) || > > > > Why is this one required? > > > > I just checked and its not needed anymore with ndk-r9. Its a leftover > from older ndk-versions that was missing something to make that check > useful. > > Would you like me to remove it and resend the patch, or if you have a > patch that solves the same issues I'm just fine with that. I'll take care of this. BTW, did you not hit some compiler errors about control reaching the end of a non-void function? I did and used the following patch (which includes your changes): http://cgit.collabora.com/git/android/platform/external/collabora/pulseaudio.git/commit/?h=jb-4.0&id=d8dc4d0e68bc3aea9cecadd9977c72827136db1c -- Arun
