Hi David,
On 04/29/2013 10:11 PM, David Henningsson wrote:
> On 04/20/2013 10:28 AM, Shuai Fan wrote:
>> This patch is my first attempt to Improve the "set log functionality".
>>
>> Any suggestions?
>
> Hi Shuai!
>
> I'm not sure what kind of suggestions you're looking for, but first
> suggestion is to use "git send-email" to send your patches instead of
> attaching them, because that makes commenting easier.
Hmm, I am learning how to send patches with "git send-email" from one
web page. A few days ago, Tanu has said to me about that, and gave me
the web page about "how to send patches with git". Thank you all the same.
>
> Also, have you actually tested the code? It looks like it would set
> the log target for the pactl client, not the server which pactl
> connects to, which is quite unexpected.
>
Well, Tanu talked about it too. I'm sorry for doing that. What should I
say, I misunderstood the goal of "set log functionality". Some days ago,
I tried to solve this problem, but I'm not sure whether what I did is
right or not. Then I sent this email, wanted to get some reply about
this stuff or something else. So, ...
> Also, did you copy-paste pa_log_parse_target from somewhere else? If
> so you should make the old code use your new function.
>
>
Yes, I did some copy-paste. But some code has been changed to implement
different function, and I was not sure the code I wrote(or changed) is
doing right or not, so I did not make the old code use my new function.
I will try to fix this stuff in the coming a few days.
BTW, Tanu also talked about the "set log functionality" stuff. He said,
in order to implement that stuff completely, the native protocol needs
to be extended, and it's a bit complicated. So I could skip pactl for now.
Best Wishes,
Shuai
