On Thu, 2013-06-27 at 21:57 +0200, David Henningsson wrote: > On 06/27/2013 06:19 PM, Tanu Kaskinen wrote: > > src/modules/alsa/alsa-mixer.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > New commits: > > commit 2613e4c74733e67d56af165df4637bf902b08508 > > Author: Tanu Kaskinen <tanu.kaskinen at linux.intel.com> > > Date: Thu Jun 27 18:47:12 2013 +0300 > > > > alsa-mixer: Add a couple of assertions > > > > I checked the code to ensure that the assertions hold currently. > > > > diff --git a/src/modules/alsa/alsa-mixer.c b/src/modules/alsa/alsa-mixer.c > > index f4410d7..b2f6c2e 100644 > > --- a/src/modules/alsa/alsa-mixer.c > > +++ b/src/modules/alsa/alsa-mixer.c > > @@ -4530,10 +4530,9 @@ void pa_alsa_path_set_add_ports( > > pa_alsa_path *path; > > void *state; > > > > + pa_assert(ps); > > pa_assert(ports); > > - > > - if (!ps) > > - return; > > Spontaneous NAK for the above change. > > I like the code the way I wrote it. Please explain. Why would you ever pass NULL path set? The whole point of the function is to generate ports from a path set. -- Tanu
