[RFC PATCH] inotify-wrapper: Quit daemon if pid file is removed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/19/2013 08:37 AM, David Henningsson wrote:
> On 04/17/2013 05:56 PM, David Henningsson wrote:
>> XDG_RUNTIME_DIR is deleted on logout (according to xdg spec), and
>> that's where we keep our pid file and native protocol socket.
>>
>> When these two files are deleted, it makes no sense to run anymore,
>> so quit. Hanging around is not only sloppy, but can also be harmful:
>> e g, if esd compat module is loaded, it will bind to the esd address.
>> When a new pulseaudio process is created on next login of the same
>> user, pulseaudio cannot start because the esd address is occupied.
>>
>> Buglink: https://bugs.launchpad.net/bugs/1167192
>> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
>> ---
>>
>> This patch is probably unfinished, because I don't know how to deal
>> with this
>> on win32 systems etc. I had to come up with a quick fix for Ubuntu
>> 13.04, and
>> this is what I came up with.
>
> I'm attaching second version of the patch. The below version could cause
> PA getting stuck in 100% CPU loop due to the event never being read out.

Bump, there were never any comments for this patch...

Is this worth caring about for 4.0, or should I keep it as a distro 
patch for now?


-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux