On Wed, 2013-01-30 at 11:04 +0100, Peter Meerwald wrote:
> From: Peter Meerwald <p.meerwald at bct-electronic.com>
>
> v2 (comments by Paul Menzel):
> * generate test samples from -1..1, -0x8000..0x7fff
> * check all output samples (not just half of them)
>
> the idea is to compare the output of the C (reference) implementation
> against the output of the optimized code path; currently, there are MMX
> and SSE implementation for the mono-to-stereo remapper for s16 and float
> sample formats
>
> Signed-off-by: Peter Meerwald <p.meerwald at bct-electronic.com>
> Cc: Paul Menzel <paulepanter at users.sourceforge.net>
> ---
> src/tests/cpu-test.c | 227 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 227 insertions(+)
Thanks! I'll apply this soon (along with patches 1-4, the rest I haven't
yet looked at). A couple of comments:
> + static void run_remap_test_mono_stereo_float(pa_remap_t *remap,
> + pa_do_remap_func_t func, pa_do_remap_func_t orig_func,
> + int align, pa_bool_t correct, pa_bool_t perf) {
Wrapped function argument lists are usually formatted like this:
static void run_remap_test_mono_stereo_float(
pa_remap_t *remap,
pa_do_remap_func_t func,
pa_do_remap_func_t orig_func,
int align,
pa_bool_t correct,
pa_bool_t perf) {
> +START_TEST (remap_sse_test) {
The test is for SSE2, so I'll change the test name to remap_sse2_test.
--
Tanu
