Hi Tanu, thank you very much for your detailed comments! I have rebased the patches to the current master and incorporated all your suggestions. Best, Stefan Stefan Huber (3): echo-cancel: Do not bypass EC implementation when play stream is empty echo-cancel: Enable different sample specs for rec and out stream echo-cancel: Warn on different sample rates for rec, play, out stream src/modules/echo-cancel/adrian.c | 34 +++--- src/modules/echo-cancel/echo-cancel.h | 36 +++--- src/modules/echo-cancel/module-echo-cancel.c | 156 ++++++++++++++------------ src/modules/echo-cancel/null.c | 15 +-- src/modules/echo-cancel/speex.c | 34 +++--- src/modules/echo-cancel/webrtc.cc | 27 +++-- 6 files changed, 168 insertions(+), 134 deletions(-) -- 1.7.9.5