On 02/12/2013 08:36 PM, Tanu Kaskinen wrote: > I started by modifying pa_card_free(), and I found myself wanting > a pa_hashmap_remove_all() function, so I started writing that. I > wanted the free_cb of that function to match the free_cb type of > pa_hashmap_free(), but pa_hashmap_free() used pa_free2_cb_t, which was > stupid, so I changed that first. Then I made the same changes to > idxset. Patches 1-7 implement this refactoring. I looked through patches 1-7 and I think they are good refactorings. -- David Henningsson, Canonical Ltd. https://launchpad.net/~diwic
